test(toggle): update snapshots #29913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Is dark mode not expected to work due to the new file imports?
There was a problem hiding this comment.
Honestly not sure why it had a black background in the first place because when you comment out the bundle files, the background is still white in the test pages.
ionic theme hasn't been set up for dark mode. For example, the list background will always be white regardless of palette. If you compare this to md, that theme is changing the background based on a global variable. The value for this variable changes based on the palette file.
brandyscarney
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Playwright was not importing the correct ionic bundle file, which has caused some snapshots to not be correct. This is apparent when a test uses
setContent. There are several components that are needing their snapshots to be re-generated. In order to not have a PR with an immense amount of snapshots, several PRs will be created to split off the work to make it easier on reviewers.The snapshots for toggle are not accurate. This can be verified by comparing it to the test pages, which do import the right bundle file.
What is the new behavior?
Does this introduce a breaking change?
Other information
Base branch