Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(modal): allow animation and add updated snapshots #29861

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

tanner-reits
Copy link
Member

Adds { animations: 'allow' } to the sheet modal tests to allow the sheet modal animations to execute before capturing their respective screenshots.

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 1:52pm

@github-actions github-actions bot added the package: core @ionic/core package label Sep 11, 2024
@brandyscarney brandyscarney changed the title test(modal): add updated snapshots test(modal): allow animation and add updated snapshots Sep 11, 2024
@tanner-reits tanner-reits marked this pull request as ready for review September 11, 2024 14:22
@tanner-reits tanner-reits requested a review from a team as a code owner September 11, 2024 14:22
@tanner-reits tanner-reits added this pull request to the merge queue Sep 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024
@tanner-reits tanner-reits added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit f4ee2bb Sep 11, 2024
49 checks passed
@tanner-reits tanner-reits deleted the tr/sheet-modal-snapshots branch September 11, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants