Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](alert, actionSheet, picker and toast): Call pressed button handler, regardless 'role' #28952

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

[fix](alert, actionSheet, picker and toast): Call pressed button handler, regardless 'role' #28952

wants to merge 25 commits into from
+314 −28

Commits on Jan 29, 2024

  1. [fix](alert): call pressed button handler, regardless 'role'

    @joselrio
    joselrio committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    5bfcd13 View commit details
    Browse the repository at this point in the history

  2. [fix](alert): rollback unintended removed line.

    @joselrio
    joselrio committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    4ce2e61 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. [fix](alert): update to improve code readability.

    @joselrio
    joselrio committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    708ad15 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Merge branch 'main' into alert-cancel-buttons-update

    @joselrio
    joselrio committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e47e139 View commit details
    Browse the repository at this point in the history

  2. [fix](alert): Run lint.fix after PR test-core-lint fail.

    @joselrio
    joselrio committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    07236f1 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. [fix](alert): Adding validation if button handler returns false.

    @joselrio
    joselrio committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    570270b View commit details
    Browse the repository at this point in the history

  2. [fix](action-sheet): call pressed button handler, regardless 'role'

    @joselrio
    joselrio committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    2be3bd9 View commit details
    Browse the repository at this point in the history

  3. [fix](picker): call pressed button handler, regardless 'role'

    @joselrio
    joselrio committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    42e0c83 View commit details
    Browse the repository at this point in the history

  4. [fix](toast): call pressed button handler, regardless 'role'

    @joselrio
    joselrio committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    14ba21b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into alert-cancel-buttons-update

    @joselrio
    joselrio committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    958a4fa View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. [fix](alert): Tests to ensure proper handler is triggered

    @joselrio
    joselrio committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    69bf9a2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into alert-cancel-buttons-update

    @joselrio
    joselrio committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    23531b4 View commit details
    Browse the repository at this point in the history

  3. [fix](alert): lint.fix

    @joselrio
    joselrio committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    693a2c3 View commit details
    Browse the repository at this point in the history

  4. [fix](alert): Method renamed.

    @joselrio
    joselrio committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    2d9761c View commit details
    Browse the repository at this point in the history

  5. [fix](picker): Tests to ensure proper handler is triggered.

    @joselrio
    joselrio committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    610e275 View commit details
    Browse the repository at this point in the history

  6. [fix](alert): lint

    @joselrio
    joselrio committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6135478 View commit details
    Browse the repository at this point in the history

  7. [fix](alert): Split cancel buttons tests.

    @joselrio
    joselrio committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    0edd1a0 View commit details
    Browse the repository at this point in the history

  8. [fix](picker): Split cancel buttons tests.

    @joselrio
    joselrio committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6967dda View commit details
    Browse the repository at this point in the history

  9. [fix](toast): Tests to ensure proper handler is triggered.

    @joselrio
    joselrio committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    621d6b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. [fix](toast): Removed unused property.

    @joselrio
    joselrio committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f01cabe View commit details
    Browse the repository at this point in the history

  2. [fix](toast): Fixed test issues and add screenshots.

    @joselrio
    joselrio committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    b0910ed View commit details
    Browse the repository at this point in the history

  3. [fix](alert): Added screenshot test.

    @joselrio
    joselrio committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    d05e653 View commit details
    Browse the repository at this point in the history

  4. [fix](picker): Added screenshot test.

    @joselrio
    joselrio committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    6ce83c4 View commit details
    Browse the repository at this point in the history

  5. [fix](toast): Fixed screenshot and test names.

    @joselrio
    joselrio committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    bbd9cda View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. test(picker): cancel button handler is called

    @sean-perkins
    sean-perkins committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    91b5b8b View commit details
    Browse the repository at this point in the history