test(angular): add comments explaining the tests

ionic-team · Aug 6, 2024 · aa31b62 · aa31b62
1 parent e8c66e6
commit aa31b62
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/packages/angular/test/base/e2e/src/lazy/router-link.spec.ts b/packages/angular/test/base/e2e/src/lazy/router-link.spec.ts
@@ -124,6 +124,11 @@ describe('Router Link', () => {
     });
   });
 
+  // Angular sets the `tabindex` to `"0"` on any element that uses
+  // the `routerLink` directive. Ionic removes the `tabindex` from
+  // components that wrap an `a` or `button` element, so we are
+  // checking here that it is only removed from Ionic components.
+  // https://github.com/ionic-team/ionic-framework/issues/20632
   describe('tabindex', () => {
     it('should have tabindex="0" with a native span', () => {
       cy.get('#span').should('have.attr', 'tabindex', '0');

diff --git a/packages/angular/test/base/e2e/src/standalone/router-link.spec.ts b/packages/angular/test/base/e2e/src/standalone/router-link.spec.ts
@@ -22,6 +22,11 @@ describe('RouterLink', () => {
     cy.url().should('include', '/standalone/popover');
   });
 
+  // Angular sets the `tabindex` to `"0"` on any element that uses
+  // the `routerLink` directive. Ionic removes the `tabindex` from
+  // components that wrap an `a` or `button` element, so we are
+  // checking here that it is only removed from Ionic components.
+  // https://github.com/ionic-team/ionic-framework/issues/20632
   it('should have tabindex="0" with a native span', () => {
     cy.get('span').should('have.attr', 'tabindex', '0');
   });