docs(component): added missing components #4186
Open
+40
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joesphchang is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
approved these changes
Jul 11, 2025
There was a problem hiding this comment.
This looks great, nice work! I have a few suggestions for the descriptions and noticed one incorrect link. I've shared it with our designer, so feel free to hold off on changes until I hear back, if that's easier. I'll let you know if they have any additional feedback. 🙂
| <DocsCard header="Action Sheet" href="api/action-sheet" img="/icons/feature-component-actionsheet-icon.png"> | ||
| <p>Action Sheets display a set of options with the ability to confirm or cancel an action.</p> | ||
| <DocsCard header="Accordion" href="api/accordion" img="/icons/feature-component-accordion-icon.png"> | ||
| <p>Accordions provide collapsible sections in your content.</p> |
There was a problem hiding this comment.
Suggested change
| <p>Accordions provide collapsible sections in your content.</p> | |
| <p>Accordions provide collapsible sections in your content to reduce vertical space while providing a way of organizing and grouping information.</p> |
| @@ -81,16 +89,19 @@ Ionic apps are made of high-level building blocks called Components, which allow | |||
| <p>Inputs provides a way for users to enter data in your app.</p> | |||
| </DocsCard> | |||
|
|
|||
| <DocsCard header="Item" href="api/item" icon="/icons/component-item-icon.png"> | |||
| <DocsCard header="Item" href="api/item" img="/icons/feature-component-item-icon.png"> | |||
| <p>Items are an all-purpose UI container that can be used as part of a list.</p> | |||
There was a problem hiding this comment.
Suggested change
| <p>Items are an all-purpose UI container that can be used as part of a list.</p> | |
| <p>Items are elements that can contain text, icons, avatars, images, inputs, and any other native or custom elements. Items can be swiped, deleted, reordered, edited, and more.</p> |
Comment on lines
+102
to
+103
| Media refers to a collection of Ionic's media-related components like ion-avatar, ion-img, ion-icon, and | ||
| ion-thumbnail. |
There was a problem hiding this comment.
Suggested change
| Media refers to a collection of Ionic's media-related components like ion-avatar, ion-img, ion-icon, and | |
| ion-thumbnail. | |
| A collection of media components, including avatars, icons, images, and thumbnails, designed to | |
| enhance visual content. |
| </DocsCard> | ||
|
|
||
| <DocsCard header="OTP Input" href="api/input-otp" icon="/icons/component-input-otp-icon.png"> | ||
| <p>Input OTP component simplifies entering one-time passwords with a customizable, multi-box interface.</p> |
There was a problem hiding this comment.
Suggested change
| <p>Input OTP component simplifies entering one-time passwords with a customizable, multi-box interface.</p> | |
| <p>OTP inputs offer a simple way to enter one-time passwords using multiple boxes with automatic focus.</p> |
| @@ -149,7 +168,11 @@ Ionic apps are made of high-level building blocks called Components, which allow | |||
| <p>Toggles are an input for binary options, often used for options and switches.</p> | |||
| </DocsCard> | |||
|
|
|||
| <DocsCard header="Toolbar" href="api/toolbar" icon="/icons/component-toolbar-icon.png"> | |||
| <p>Toolbars are used to house information and actions relating to your app.</p> | |||
| <DocsCard header="Toolbar" href="api/toolbar" icon="/icons/component-toolbar-icon.png"> | |||
There was a problem hiding this comment.
Why are some of these not indented? Is the linter messing it up?
| @@ -101,6 +112,14 @@ Ionic apps are made of high-level building blocks called Components, which allow | |||
| <p>Modals slide in and off screen to display a temporary UI and are often used for login or sign-up pages.</p> | |||
| </DocsCard> | |||
|
|
|||
| <DocsCard header="Navigation" href="api/menu" icon="/icons/component-navigation-icon.png"> | |||
There was a problem hiding this comment.
Suggested change
| <DocsCard header="Navigation" href="api/menu" icon="/icons/component-navigation-icon.png"> | |
| <DocsCard header="Navigation" href="api/nav" icon="/icons/component-navigation-icon.png"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3986
Changes I made