-
Notifications
You must be signed in to change notification settings - Fork 3.2k
docs(config): add code snippets of how to access the mode per framework #4147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tested all examples with and without the import as mentioned in `https://github.com/ionic-team/ionic-docs/issues/4095`. Components maintain full functionality without this import.
… for method parameters generated in renderMethods function
Infinite scroll (ionic-team#4095)
docs(docusaurus): add method parameter documentation to methods (ionic-team#634)
docs(config): added ionic-mode docs to Reading the Config"
@joesphchang is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for this! I spoke with the team, and we think it would be clearer if getting the mode were its own section, separate from the get method. This helps make it more obvious that the get method isn't available in all frameworks. For example, Angular would remain the same: ![]() And a new section would be added, either before or after the Angular one: ![]() Additionally, we should make sure that all framework examples are consistent. This would be a good use case for adding a playground if we want to apply styles based on the mode. You can see an example of a playground in a guide page here: https://ionicframework.com/docs/utilities/gestures#basic-gestures And the source code for that example is here: https://github.com/ionic-team/ionic-docs/tree/main/static/usage/v8/gestures/basic Lastly, we need to make sure this documentation is also added to the v7 directories:
Let me know if you have any questions! |
…t ngFor in 2-taking-photos.md
…ck to 3-saving-photos.md
…-loading-photos.md
…ryCodeContext docs(angular): "Your First App" tutorial should show complete code context (ionic-team#2082)
…ighting bug: diff code blocks used but not supported (ionic-team#4156)
Added ionic-mode to the appropriate section in Config
Initial issue: Issue #2580