docs(input-otp): add documentation for new input-otp component #4112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
brandyscarney
requested review from
thetaPC and
ShaneK
and removed request for
a team
thetaPC
requested changes
May 22, 2025
Comment on lines
+87
to
+93
| The component supports various states for automatic styling of input boxes: | ||
| - `disabled` and `readonly` states via respective properties | ||
| - Form validation states: `valid` and `invalid` visually indicated through CSS classes | ||
| - In Angular: validation states are automatically managed through the framework's value accessors and form validation | ||
| - For other frameworks: developers must manually add `ion-valid`, `ion-invalid`, and `ion-touched` classes | ||
| - `ion-invalid` styles only display when touched (`ion-touched`) | ||
| - `ion-valid` styles only display when focused (`has-focus`) |
There was a problem hiding this comment.
We should also update the other input pages to reflect this (in another PR).
ShaneK
approved these changes
May 29, 2025
There was a problem hiding this comment.
This looks really good to me! It's a bummer it's so difficult to get it into the component list, would be cool to have it there, but I understand. I indicated places where you left TODOs for before you merge - I think you were going to handle this before merging and just wanted the preview to work for review, I just wanted to make sure they weren't forgotten just in case haha
Looks and works great, though!
brandyscarney
added a commit
that referenced
this pull request
Jun 4, 2025
Co-authored-by: Brandy Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation & playgrounds for the new
ion-input-otpcomponent.Preview