fix: sending success when error #2
Open
+113
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andredestro
force-pushed
the
feat/RMET-4048/implementation
branch
from
76ad606 to
6971b89
Compare
OS-pedrogustavobilro
approved these changes
May 2, 2025
andredestro
force-pushed
the
feat/RMET-4048/implementation
branch
from
6971b89 to
04ec617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue which was causing a false success
Type of changes
Tests
IONFLTRUploadDelegateTests
✓ testDidCompleteWithSuccess_shouldSendSuccess (0.001 seconds)
✓ testDidReceiveData_shouldAccumulateData (0.001 seconds)
Checklist