feat(statusbar)!: implement overlay and background color in iOS #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andredestro
force-pushed
the
plugin/statusbar/implement-overlay-and-color
branch
6 times, most recently
from
c642139
to
f6d9794
Compare
andredestro
force-pushed
the
plugin/statusbar/implement-overlay-and-color
branch
from
f6d9794
to
aac805f
Compare
theproducer
changed the title
theproducer
requested changes
Aug 22, 2024
status-bar/android/src/main/java/com/capacitorjs/plugins/statusbar/StatusBarPlugin.java
Outdated
Show resolved
Hide resolved
|
Released dev build of status-bar with dev version: 6.0.2-dev-2179-20240905T142731.0 |
markemer
reviewed
Aug 22, 2024
| if let observer = observer { | ||
| NotificationCenter.default.removeObserver(observer) | ||
|
|
||
| private func style(fromString: String) -> UIStatusBarStyle { |
There was a problem hiding this comment.
Doesn't need to happen for this PR, but we could make this an init() on the style enum and have a computer variable that gives us a UIStatusBarStyle on the enum as well. Just putting that out into the ether for the future.
markemer
reviewed
Aug 22, 2024
markemer
reviewed
Aug 22, 2024
status-bar/android/src/main/java/com/capacitorjs/plugins/statusbar/StatusBarConfig.java
Show resolved
Hide resolved
andredestro
requested review from
markemer,
Chuckytuh,
jcesarmobile and
usernuno
theproducer
requested changes
Aug 27, 2024
status-bar/android/src/main/java/com/capacitorjs/plugins/statusbar/StatusBar.java
Outdated
Show resolved
Hide resolved
andredestro
force-pushed
the
plugin/statusbar/implement-overlay-and-color
branch
from
dd92e88
to
9befd42
Compare
markemer
reviewed
Sep 4, 2024
theproducer
requested changes
Sep 5, 2024
andredestro
force-pushed
the
plugin/statusbar/implement-overlay-and-color
branch
from
adb9d98
to
fd03e47
Compare
markemer
approved these changes
Sep 5, 2024
theproducer
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.