-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(keyboard): Improvements to keyboard show / hide events #1980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always love removing direct frame math.
Released dev build of keyboard with dev version: 6.0.0-dev-1980-20240123T163013.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removing the resizeOnFullScreen
feature (https://capacitorjs.com/docs/apis/keyboard#configuration)
I don't think that's intended, the resizeOnFullScreen
feature should continue to work.
What exactly is the breaking change here? I'm upgrading from Capacitor v5 to v6 and this change is not documented. So trying to figure out what potential impact this PR might have |
I've just upgraded to Capacitor v6 and noticed that the recent PR not only refactors but also changes how the keyboard height is calculated to include the navigation gesture bar. The keyboard height can vary depending on whether a user uses three-button navigation or swipe gesture navigation. This added value makes it impossible to predict the keyboard's height within the bounds of our Capacitor web view. For our use case, we need to either roll back these changes or amend them to exclude the navigation bar height. Is anyone else encountering this issue? |
@tobeagram I have the same issue too |
This PR breaks keyboard listeners on Android <= 10 devices when What is working:
|
Also have this issue, downgrading for now. I will create an issue to track this. |
See #2168, might get more visibility there rather than commenting on this PR. |
No description provided.