Update to support latest QUnit #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qunit version upgrade: qunitjs#110
travis status icon
set the upstream build status
temporarily change it back to not interfere with tests that are already broken
Upgrade qunitjs version once more...
The error is caused by this 1.10.0 to 1.16.0 upgrade
travis build status icon
Default reporters lcov, json with a way to specify it from runner
Test on nodejs 0.12
Add node v4 support
allow coverage instrumentation of multiple files
Directory coverage
Added parsing of the maxBlockDuration config from the command line.
… the `assert.async()` method instead of `start()` and `stop()`
Upgrade QUnitJS from 1.10.0 to 1.23.1
Collaborator
|
Ok thanks, I'm considering to retry to load qunit modules with the latest master of the original line (since many things are updated), and in case completely remove my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how these changes might meld with your code, but I'm offering the PR in case you may consider updating. @yomexzo's changes seem to get things working for the latest QUnit API. I am submitting the changes to you since your
grunt-node-qunitis depending on this repo (asluckysw/node-qunit) which doesn't support the latest QUnit.If you need to preserve some of your own changes (and not just adapt @yomexzo's version), I'd suggest submitting them back to @kof and/or @yomexzo, so we can have some sanity.