Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for importing PGN into study #53

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

yzoug
Copy link
Contributor

@yzoug yzoug commented Mar 2, 2024

This PR adds the ability to send a PGN into a study (this endpoint).

I tested this (all chapters in this study are imported using this code) with no issues.

I have begun work to implement the whole Studies API endpoint. However, the output of the Lichess API is very messy: we need to parse a non-standard data format (application/chess-x-pgn). You can see my first try in this PR (not mergeable).

Will maybe continue working on this but I think it won't be the most used feature of the Lichess API: it's way easier to consult studies directly on the Lichess interface. However, sending a PGN into a study is something more people would want to do (at least, I will need this for my project).

If someone wants to give it a go to implement the rest of the Studies API endpoint I can help! But as you can see in the linked PR above, it's a mess :/

@yzoug
Copy link
Contributor Author

yzoug commented Mar 2, 2024

PS: if merged, the issue #26 can be updated to reflect that this endpoint is supported

@ion232
Copy link
Owner

ion232 commented Apr 17, 2024

Sorry for the late review - thanks for the changes.

@ion232 ion232 merged commit 4c4043d into ion232:main Apr 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants