-
-
Notifications
You must be signed in to change notification settings - Fork 59
Add repoReadTime field to RepoInfo interface for repository read timing #3102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: GermanBluefox <[email protected]>
Co-authored-by: GermanBluefox <[email protected]>
|
@copilot do not rebuild repository, as it is impossible to detect relevant changes in 300 files. The repository will be rebuilt when publishing |
…g change Co-authored-by: GermanBluefox <[email protected]>
Done! I've reverted all the auto-generated documentation changes and kept only the essential typing change to |
GermanBluefox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Apollon77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Please revert the package-lock.json file. this should not change
Apollon77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Revert the changes to the package-lock.json file
Co-authored-by: Apollon77 <[email protected]>
Apollon77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed @GermanBluefox I do not really like the name, of the field because e.g. "previousRepoReadTime" or such would be more descriptive .. but thats in the end nits
|
Admin already utilzes that already. So we can merge it |
repoReadTime?: stringfield to theRepoInfointerface inpackages/types-dev/objects.d.tsChanges Made
repoReadTime?: stringfield to theRepoInfointerface inpackages/types-dev/objects.d.ts?) and follows the same pattern as the existingrepoTimefieldTechnical Details
The
RepoInfointerface now includes:stable?: boolean- If it is the official stable repositoryname: Required<ioBroker.Translated>- i18n name of the repositoryrepoTime: string- Time of repository updaterepoReadTime?: string- Time when repository was last read/fetched (new)This change maintains backward compatibility as the new field is optional, and follows the existing coding patterns in the codebase. The PR contains only the minimal necessary change (1 file, 2 lines added) to avoid triggering a massive repository rebuild.
Fixes #3101.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.