Fix for DEIS / DPM++ config clash by setting algorithm type - fixes #6368 #7440
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vargol
requested review from
blessedcoolant,
psychedelicious,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
python
|
Know that this is not going unnoticed - thanks for the contribution! We'll plan on having @RyanJDick review and approve before we release next - he’s just sprinting to finish line on Flux stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a model defaults to DEIS scheduler and the user attempts to use DPM++ schedulers with it, the inherited config parameters clash giving #6368, this fixes it by changing the config to use DPM's default alogorythm type, which I
believe is was a user attempt to using the DPM++ would expect.
Related Issues / Discussions
Closes #6368
QA Instructions
Run a Dreamshaper 8 render using any of the following schedulers
DPM++ 2M
DPM++ 2M Karras
DPM++ 2S
DPM++ 2S Karras
It will fail without the pull request, and will work with the pull request.
Merge Plan
N/A simple merge