Closed
Conversation
blessedcoolant
requested review from
RyanJDick,
brandonrising,
hipsterusername,
lstein and
psychedelicious
as code owners
github-actions
Bot
added
python
lstein
approved these changes
Aug 10, 2024
Collaborator
lstein
left a comment
lstein
left a comment
There was a problem hiding this comment.
Looks good to me. Happy to see that load_remote_model() is working as intended.
A node to generate normal, roughness and displacement maps from a single image. Based on: https://github.com/joeyballentine/Material-Map-Generator
hipsterusername
force-pushed
the
pbr-maps
branch
from
380c00f to
1388f85
Compare
Member
|
@psychedelicious @RyanJDick @brandonrising - I imagine we want to handle these models differently, thinking about new user UX (and hosting these)? |
Collaborator
Author
|
I think it's better we host them ourselves. The Github downloads can take ridiculously long sometimes for no apparent reason. The UI use case would be currently right click on an image and say "Generate PBR Maps" from it. Ideally we want to do a proper 3D viewer for previewing the model but that's an entirely different feature. |
Collaborator
|
Resurrect! |
Collaborator
Author
Resurrected. But now with UI implementation too. #8700 Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A node to generate normal, roughness and displacement maps from a single image. Based on: https://github.com/joeyballentine/Material-Map-Generator