-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Disable email template #270
[Feature] Disable email template #270
Conversation
…hange email template
I don't think we should just hide input. My suggestion would be to replace the markdown component with Nonetheless, I think this needs to be updated with the CTA button as we discussed in Slack. |
@beganovich @turbo124 here is the screenshot how it looks with replaced button. |
@turbo124 thoughts? |
This looks fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, small changes are needed 👍
/> | ||
) : ( | ||
<div className="flex flex-col items-start"> | ||
<span className=" text-gray-500" style={{ fontSize: 12 }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove blank space before
text-gray-500
- Use Tailwind representation for text size (probably you'll need
text-sm
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove blank space before
text-gray-500
- Use Tailwind representation for text size (probably you'll need
text-sm
.
Fixed
Email body template can be changed on{' '} | ||
<strong>Enterprise/Pro</strong> plan. | ||
</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be replaced with a translatable string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be replaced with a translatable string.
Added
@turbo124 Regarding missed key for translation, please just include this one. |
Thanks 👍 |
@beganovich I've been looking for a solution to disable the MDEditor component from the @uiw/react-md-editor npm package, but I haven't found one. Here's a link to the source where I found it's not yet possible for this component: jrm2k6/react-markdown-editor#56. Please let me know if I'm wrong.
@turbo124 Regarding this situation that I don't have permission to disable this component, I decided not to show this component if the user is not allowed to do so. Please let me know if you agree with this kind of solution if Ben confirms that disabling is not possible.
Here is the screenshot of how it looks without body template: