feat(firestore): added support for non-default databases#8489
Merged
mikehardy merged 4 commits intoinvertase:mainfrom Jul 9, 2025
Merged
feat(firestore): added support for non-default databases#8489mikehardy merged 4 commits intoinvertase:mainfrom
mikehardy merged 4 commits intoinvertase:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
MichaelVerdon
changed the title
MichaelVerdon
suggested changes
Apr 28, 2025
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Contributor
|
Hey there 👋 , if I don't receive an update on whether you will add tests or not I will go and add them myself. (You will still get credited for this PR so don't worry about that). |
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
Noting from issue thread: If unit tests are a barrier to merge, we need to add them to get this through, user commented that adding them isn't within capacity at the moment |
MichaelVerdon
changed the title
MichaelVerdon
force-pushed
the
feat-support-alternate-databses
branch
from
e4518e6 to
457ebcd
Compare
mikehardy
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for initalizing firestore with a non-default database
Related issues
Fixes #8456
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__