Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: install details for expo build properties #7856

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Conor-Hinchee
Copy link

Description

I am wanting to add some clarification in the getting started guide when following the Expo path and iOS build.

Documentation currently indicates that configuration of expo-build-properties in app.json is required but it seems to be missing details that the package must be installed.

Hoping this helps to add clarity.

Referencing this StackOverflow question

Related issues

N/A

Release Summary

Docs: Added clarity to the getting started guide for iOS + Expo

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 3:01pm

@CLAassistant
Copy link

CLAassistant commented Jun 21, 2024

CLA assistant check
All committers have signed the CLA.

@Conor-Hinchee Conor-Hinchee changed the title docs/added-install-details-for-expo-build-properties docs: install details for expo build properties Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants