feat: style packages versions in administration panel #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ntarocco
commented
Sep 11, 2024
•
ntarocco
commented
- closes Show packages versions in the administration panel invenio-app-rdm#2838
ntarocco
force-pushed
the
feature/admin-display-version
branch
2 times, most recently
from
18ff068 to
dd595aa
Compare
ntarocco
force-pushed
the
feature/admin-display-version
branch
from
dd595aa to
171f058
Compare
kpsherva
reviewed
Sep 12, 2024
| @@ -108,6 +108,8 @@ | |||
| } | |||
|
|
|||
| & > .side-bar.column { | |||
| display: flex; | |||
| flex-direction: column; | |||
| min-height: 100vh; | |||
There was a problem hiding this comment.
follow up on what we discussed about the sidebar height
Suggested change
| min-height: 100vh; | |
| min-height: calc(100vh - @relative75px); |
it will fix it (already tested). The header height was not taken into account
kpsherva
approved these changes
Sep 12, 2024
ntarocco
force-pushed
the
feature/admin-display-version
branch
from
171f058 to
b9aed66
Compare
jrcastro2
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.