Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navbar: update logo size in non-desktop devices #392

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

M3nin0
Copy link
Member

@M3nin0 M3nin0 commented Aug 11, 2024

❤️ Thank you for your contribution!

Description

The behavior described and updated in this PR was identified in InvenioRDM v12 with invenio-theme version 3.3.0

The navbar logo size does not adjust immediately when transitioning from the computer to tablet breakpoint (1300px). It changes only when the page width is below 1200px. The GIF below demonstrates this behavior.

issue-01

This PR fixes this behavior by updating the image media query, ensuring the logo size changes consistently at the appropriate breakpoint. The GIF below presents the result of the proposed modification.

issue-02

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@kpsherva kpsherva merged commit 75b8e2f into inveniosoftware:master Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants