Revert "global: remove breadcrumbs" #384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1cec836.
|
Why it should be reverted? |
|
it will be removed in the next PR's. those package you mention have pinned invenio-theme to <3.0.0. |
Flask-breadcrubms is still being used al around invenio, see here: https://github.com/search?q=org%3Ainveniosoftware+flask_breadcrumbs&type=code Some repos started to fail due to this, f.e. https://github.com/inveniosoftware/invenio-files-rest or inveniosoftware/invenio-oauthclient#324 Just wondering why it was decided to remove it from invenio-theme? I might be missing something |
|
Discussed IRL with @utnapischtim, not needed as we will remove flask-breadcrumbs from all other repositories. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1cec836.
Flask-breadcrumbs is still being used all around invenio, see: https://github.com/search?q=org%3Ainveniosoftware+flask_breadcrumbs&type=code