feat(requests): Add conversation locking functionality #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakshamarora1
force-pushed
the
feature/locking_requests
branch
from
d7c6467 to
b4823e1
Compare
sakshamarora1
force-pushed
the
feature/locking_requests
branch
from
b4823e1 to
f6dff91
Compare
zzacharo
reviewed
Nov 28, 2025
| def update(self, identity, data=None, record=None, uow=None, **kwargs): | ||
| """Update the reviewers of a request.""" | ||
| if "reviewers" in data: | ||
| if data.get("reviewers", None): |
Member
There was a problem hiding this comment.
This should not change because it adds a regression when we remove reviewers
| """Condition to choose generators set.""" | ||
| # If the event type is a log event, we don't need to check if the request is locked | ||
| # Because it's not a comment event and we don't want to block logs | ||
| if event_type and event_type == LogEventType: |
Member
There was a problem hiding this comment.
I find this odd here and I know that it comes from the fact that the events_service.create assumes permission based on adding comments and not log events. Isnt it better to change the check of permission on the service method to explicitely check the event.type and apply correct permissions? @slint wdyt?
sakshamarora1
force-pushed
the
feature/locking_requests
branch
from
d4d0947 to
52716be
Compare
zzacharo
reviewed
Dec 4, 2025
| self.require_permission(identity, "lock_request", request=request._record) | ||
|
|
||
| if request.data["is_locked"]: | ||
| raise RequestLockedError(description="The request is already locked.") |
| self.require_permission(identity, "lock_request", request=request._record) | ||
|
|
||
| if not request.data["is_locked"]: | ||
| raise RequestLockedError(description="The request is already unlocked.") |
sakshamarora1
force-pushed
the
feature/locking_requests
branch
3 times, most recently
from
d1d10b9 to
e033375
Compare
sakshamarora1
force-pushed
the
feature/locking_requests
branch
from
e033375 to
35e0200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #498