Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job: refactor args #60

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

ntarocco
Copy link
Contributor

@ntarocco ntarocco commented Oct 10, 2024

  • adds PredefinedArgsSchema schema class with predefined args, including
    since.
  • changes JobType public/private interface to make it easier to define
    your own job types
  • logs celery tasks error message and shows it in the UI
  • removes unused code

invenio_jobs/jobs.py Outdated Show resolved Hide resolved
invenio_jobs/jobs.py Outdated Show resolved Hide resolved
@ntarocco
Copy link
Contributor Author

ntarocco commented Oct 12, 2024

Unresolved UI issues:

  1. The Run form, from the list of runs, is not rendering any parameter
    Screenshot 2024-10-12 at 18 46 50

  2. In the runs list, there is an extra col. In general, buttons are not rendering nicely
    Screenshot 2024-10-12 at 18 47 45

  3. There is a general inconsistency between Edit buttons in the various admin panels

  4. When creating a new Job, there is a Default queue, when running an existing it is called celery?
    Screenshot 2024-10-12 at 18 57 13
    Screenshot 2024-10-12 at 18 57 03

  5. The last run date is not nicely formatted
    Screenshot 2024-10-12 at 18 57 25

  6. When expanding an error, the column will expand to fit the text
    Screenshot 2024-10-12 at 18 57 40

  7. There is a console error highlighting that the defaultSortingOnEmptyQueryString should be an object and not an array. From the DOM:
    defaultSortingOnEmptyQueryString": [{"sortBy": "last_run_start_time"}]

@@ -101,31 +101,24 @@ class SearchResultItemComponent extends Component {
/>
</>
) : (
""
"-"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was there something wrong 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was some weird char instead of -

Copy link
Contributor

@carlinmack carlinmack Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was intentionally chosen as normal n-dashes look too short: -

I prefer an em-dash: —

But went with one in between to be a bit fancy: −

Unless there is a problem with the character not displaying I don't see why not choose something that looks better

@ntarocco ntarocco force-pushed the refactor-jobs branch 3 times, most recently from acabc52 to 4d562d1 Compare October 14, 2024 12:17
* adds PredefinedArgsSchema schema class with predefined args, including
  `since`.
* changes JobType public/private interface to make it easier to define
  your own job types
* logs celery tasks error message and shows it in the UI
* removes unused code
@kpsherva kpsherva merged commit c3721f0 into inveniosoftware:master Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants