feat(vcs): view handlers #195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
13 tasks
* Updated the view handlers and the Jinja templates to accommodate the new generic structure. The view handlers needed only relatively small changes, but the Jinja templates had to have all references to 'GitHub', the GitHub logo, and GitHub URLs replaced with provider-specific references. The 'vocabulary' defined in the `RepositoryServiceProviderFactory` specifies the terminology that should be used for a given VCS, including the name/icon but also the word for 'repository' which is 'project' for GitLab. * The `ext.py` file is also changed here to reflect the dynamic submenu entries depending on the VCS providers registered in the config. * This commit on its own is UNRELEASABLE. We will merge multiple commits related to the VCS upgrade into the `vcs-staging` branch and then merge them all into `master` once we have a fully release-ready prototype. At that point, we will create a squash commit.
* We are now distributing this module as an optional dependency rather than pre-bundled with InvenioRDM. So the new way of activating/deactivating the module is installing/uninstalling it. * Also, the default value for `VCS_PROVIDERS` is an empty list, so nothing would be rendered in the UI menu anyway.
palkerecsenyi
force-pushed
the
views-layer
branch
from
bb92fb9 to
fbcd1b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188
Updated the view handlers and the Jinja templates to accommodate the new generic structure. The view handlers needed only relatively small changes, but the Jinja templates had to have all references to 'GitHub', the GitHub logo, and GitHub URLs replaced with provider-specific references. The 'vocabulary' defined in the
RepositoryServiceProviderFactoryspecifies the terminology that should be used for a given VCS, including the name/icon but also the word for 'repository' which is 'project' for GitLab.The
ext.pyfile is also changed here to reflect the dynamic submenu entries depending on the VCS providers registered in the config.This commit on its own is UNRELEASABLE. We will merge multiple commits related to the VCS upgrade into the
vcs-stagingbranch and then merge them all intomasteronce we have a fully release-ready prototype. At that point, we will create a squash commit.