details header: remove hardcoded header, remove empty tabs #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
reviewed
Aug 14, 2023
invenio_communities/templates/semantic-ui/invenio_communities/details/header.html
Outdated
Show resolved
Hide resolved
jennur
force-pushed
the
community-tabs
branch
7 times, most recently
from
b944849
to
b77efb4
Compare
slint
reviewed
Aug 16, 2023
invenio_communities/templates/semantic-ui/invenio_communities/details/header.html
Outdated
Show resolved
Hide resolved
slint
reviewed
Aug 16, 2023
kpsherva
approved these changes
Aug 16, 2023
ntarocco
reviewed
Aug 17, 2023
| @@ -29,6 +29,7 @@ def view(**kwargs): | |||
| id_=pid_value, identity=g.identity | |||
| ) | |||
| kwargs["community"] = community | |||
| request.community = community.to_dict() | |||
There was a problem hiding this comment.
We normally use the g context, and not the request context. From the Flask doc:
- g:
This is a good place to store resources during a request. - request:
To access incoming request data, you can use the global request object. Flask parses incoming request data for you and gives you access to it through that global object.
Minor: community.to_dict() is repeated below, it could be set once, and re-used.
Moderate: can you add a comment to explain why? It won't be easy to understand why this was done, and it might break quite easily.
| @@ -65,6 +65,26 @@ def _can_create_community(): | |||
| return can_create | |||
|
|
|||
|
|
|||
| def _has_about_page_content(): | |||
| """Function used to check if about page has content.""" | |||
| community = request.community | |||
There was a problem hiding this comment.
See comment above about using g instead. Very minor: I would also call it current_community to make it very clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/zenodo/rdm-project/issues/172, closes inveniosoftware/invenio-app-rdm#2327
No page contents added:
Only curation policy content added:
Both added: