Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

members: patch pagination rendering to prevent infinite negative numbers #1137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Samk13
Copy link
Member

@Samk13 Samk13 commented May 28, 2024

❤️ Thank you for your contribution!

Description

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@Samk13 Samk13 force-pushed the member-pagination-fix branch 2 times, most recently from 1250667 to 1c7f839 Compare May 29, 2024 06:35
@Samk13
Copy link
Member Author

Samk13 commented Jun 5, 2024

Adding showWhenOnlyOnePage from 268 seems to have no effect on this.

@anikachurilova
Copy link
Contributor

Thank you for taking care of this! Good job 🚀
After having a look and doing a quick test, the pagination still seems to be not appearing when there are more results found than shown on the page (see the screenshot)
Screenshot 2024-06-26 at 13 25 03
Please correct me if I am checking something wrong!

@Samk13 Samk13 force-pushed the member-pagination-fix branch 4 times, most recently from 8e51f16 to 5baf723 Compare June 26, 2024 14:27
@Samk13
Copy link
Member Author

Samk13 commented Jun 26, 2024

@anikachurilova
I've updated the value, which works as expected for numbers under the default pagination value.

However, the issue persists with larger numbers than the default pagination value.

Update: This PR fixes the issue.
In this PR I added showWhenOnlyOnePage so it will not show pagination unless needed.

@Samk13
Copy link
Member Author

Samk13 commented Jun 26, 2024

Final result:

test-pagination-4

@Samk13 Samk13 force-pushed the member-pagination-fix branch 2 times, most recently from 5a3049d to 0b04e17 Compare June 26, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To review
Development

Successfully merging this pull request may close these issues.

Pagination Error When Using Search Function in Community Members Tab
2 participants