Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination Error When Using Search Function in Community Members Tab #1136

Open
Samk13 opened this issue May 28, 2024 · 1 comment · May be fixed by #1137 or inveniosoftware/react-searchkit#276
Open

Pagination Error When Using Search Function in Community Members Tab #1136

Samk13 opened this issue May 28, 2024 · 1 comment · May be fixed by #1137 or inveniosoftware/react-searchkit#276
Labels
Type: bug

Comments

@Samk13
Copy link
Member

Samk13 commented May 28, 2024 •
edited
Loading

Package version (if known): v12 latest, invenio-communities: v13.0.3

Describe the bug

A clear and concise description of what the bug is.

Steps to Reproduce

  • Go to the 'Members' tab in a community.
  • Click on the search button.
  • Observe the pagination at the bottom of the page.

Expected behavior

The pagination should correctly display the available page numbers without any erratic behavior.

Screenshots (if applicable)

Additional context

Screenshot from 2024-05-29 01-14-26

Screencast.from.2024-05-28.16.07.46.webm
@Samk13
Copy link
Member Author

Samk13 commented May 28, 2024

From a quick read, this might be related: #954

Samk13 added a commit to Samk13/invenio-communities that referenced this issue May 28, 2024
@Samk13
members: patch pagination rendering to prevent infinite negative numbers
42ed8bc 
* Conditionally render the Pagination component based on total results
* Only show Pagination if total results exceed results per page
* Ensures cleaner UI and prevents unnecessary pagination rendering
* Closes inveniosoftware#1136
Samk13 added a commit to Samk13/invenio-communities that referenced this issue May 28, 2024
@Samk13
members: patch pagination rendering to prevent infinite negative numbers
4328f38 
* Conditionally render the Pagination component based on total results
* Only show Pagination if total results exceed results per page
* Ensures cleaner UI and prevents unnecessary pagination rendering
* Closes inveniosoftware#1136
@Samk13 Samk13 linked a pull request May 28, 2024 that will close this issue
Open
10 tasks
Samk13 added a commit to Samk13/invenio-communities that referenced this issue May 28, 2024
@Samk13
members: patch pagination rendering to prevent infinite negative numbers
1250667 
* Conditionally render the Pagination component based on total results
* Only show Pagination if total results exceed results per page
* Ensures cleaner UI and prevents unnecessary pagination rendering
* Closes inveniosoftware#1136
Samk13 added a commit to Samk13/invenio-communities that referenced this issue May 29, 2024
@Samk13
members: patch pagination rendering to prevent infinite negative numbers
1c7f839 
* Conditionally render the Pagination component based on total results
* Only show Pagination if total results exceed results per page
* Ensures cleaner UI and prevents unnecessary pagination rendering
* Closes inveniosoftware#1136
Samk13 added a commit to Samk13/invenio-communities that referenced this issue Jun 5, 2024
@Samk13
members: patch pagination rendering to prevent infinite negative numbers
4174b6d 
* Conditionally render the Pagination component based on total results
* Only show Pagination if total results exceed results per page
* Ensures cleaner UI and prevents unnecessary pagination rendering
* Closes inveniosoftware#1136
@Samk13 Samk13 mentioned this issue Jun 16, 2024
Closed
Samk13 added a commit to Samk13/invenio-communities that referenced this issue Jun 26, 2024
@Samk13
members: patch pagination rendering to prevent infinite negative numbers
a021bc5 
* Conditionally render the Pagination component based on total results
* Only show Pagination if total results exceed results per page
* Ensures cleaner UI and prevents unnecessary pagination rendering
* Closes inveniosoftware#1136
Samk13 added a commit to Samk13/invenio-communities that referenced this issue Jun 26, 2024
@Samk13
members: patch pagination rendering to prevent infinite negative numbers
56d9652 
* Conditionally render the Pagination component based on total results
* Only show Pagination if total results exceed results per page
* Ensures cleaner UI and prevents unnecessary pagination rendering
* Closes inveniosoftware#1136
Samk13 added a commit to Samk13/invenio-communities that referenced this issue Jun 26, 2024
@Samk13
members: patch pagination rendering to prevent infinite negative numbers
8e51f16 
* Conditionally render the Pagination component based on total results
* Only show Pagination if total results exceed results per page
* Ensures cleaner UI and prevents unnecessary pagination rendering
* Closes inveniosoftware#1136
Samk13 added a commit to Samk13/invenio-communities that referenced this issue Jun 26, 2024
@Samk13
members: patch pagination rendering to prevent infinite negative numbers
5baf723 
* Conditionally render the Pagination component based on total results
* Only show Pagination if total results exceed results per page
* Ensures cleaner UI and prevents unnecessary pagination rendering
* Closes inveniosoftware#1136
Samk13 added a commit to Samk13/invenio-communities that referenced this issue Jun 26, 2024
@Samk13
members: patch pagination rendering to prevent infinite negative numbers
7c91b24 
* Conditionally render the Pagination component based on total results
* Only show Pagination if total results exceed results per page
* Ensures cleaner UI and prevents unnecessary pagination rendering
* Closes inveniosoftware#1136
Samk13 added a commit to Samk13/react-searchkit that referenced this issue Jun 26, 2024
@Samk13
pagination: fix negative pagination
53c0165 
* closes inveniosoftware/invenio-communities#1136
@Samk13 Samk13 linked a pull request Jun 26, 2024 that will close this issue
Open
10 tasks
Samk13 added a commit to Samk13/invenio-communities that referenced this issue Jun 26, 2024
@Samk13
members: hide pagination if its not needed
5a3049d 
* Closes inveniosoftware#1136
Samk13 added a commit to Samk13/react-searchkit that referenced this issue Jun 26, 2024
@Samk13
pagination: fix negative pagination
c8330a9 
* closes inveniosoftware/invenio-communities#1136
Samk13 added a commit to Samk13/invenio-communities that referenced this issue Jun 26, 2024
@Samk13
members: hide pagination if its not needed
0b04e17 
* Closes inveniosoftware#1136
Samk13 added a commit to Samk13/invenio-communities that referenced this issue Jun 27, 2024
@Samk13
members: hide pagination if its not needed
8bf0e79 
* Closes inveniosoftware#1136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: bug
Projects
None yet
Milestone
No milestone
1 participant
@Samk13