subcommunities: check for parent children allow

invenio_communities/subcommunities/resources/config.py

@@ -6,16 +6,20 @@
 # it under the terms of the MIT License; see LICENSE file for more details.
 """Subcommunity resource configuration."""
 from flask_resources import (
+    HTTPJSONException,
     JSONDeserializer,
     JSONSerializer,
     RequestBodyParser,
     ResourceConfig,
     ResponseHandler,
+    create_error_handler,
 )
 from invenio_records_resources.resources.records.headers import etag_headers
 from invenio_records_resources.services.base.config import ConfiguratorMixin
 from marshmallow import fields
 
+from ..services.errors import ParentChildrenNotAllowed
+
 
 class SubCommunityResourceConfig(ConfiguratorMixin, ResourceConfig):
     """Subcommunity resource configuration."""
@@ -41,3 +45,14 @@ class SubCommunityResourceConfig(ConfiguratorMixin, ResourceConfig):
         "application/json": ResponseHandler(JSONSerializer(), headers=etag_headers)
     }
     default_accept_mimetype = "application/json"
+
+    # Error handling
+    error_handlers = {
+        # Parent community does not allow children
+        ParentChildrenNotAllowed: create_error_handler(
+            lambda e: HTTPJSONException(
+                code=400,
+                description=str(e),
+            )
+        ),
+    }

invenio_communities/subcommunities/services/service.py

@@ -17,6 +17,8 @@
 import invenio_communities.notifications.builders as notifications
 from invenio_communities.proxies import current_communities, current_roles
 
+from .errors import ParentChildrenNotAllowed
+
 community_service = LocalProxy(lambda: current_communities.service)
 
 
@@ -76,6 +78,12 @@ def join(self, identity, id_, data, uow=None):
         denied, the transaction will be rolled back.
         """
         parent_community = community_service.record_cls.pid.resolve(id_)
+
+        if not parent_community.children.allow:
+            raise ParentChildrenNotAllowed(
+                _("Parent community does not accept subcommunities.")
+            )
+
         data_, errors = self.schema.load(
             data,
             context={"identity": identity, "community": parent_community},
@@ -122,7 +130,9 @@ def join(self, identity, id_, data, uow=None):
 
         is_owner_parent = self._is_owner_of(identity, str(id_))
         if is_owner_child and is_owner_parent:
-            request = requests_service.execute_action(identity, request.id, "accept")
+            request = requests_service.execute_action(
+                identity, request.id, "accept", uow=uow
+            )
 
         return request