records/macros/detail.html: Allow funding entry with award number only

[karkraeg]

❤️ Thank you for your contribution!

Description

In order to display funding entries with only an award number after inveniosoftware/invenio-vocabularies#429 has been merged this PR changes the display logic.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

1. You license your contribution under the same terms as the current repository’s license.
2. You agree that you have the right to license your contribution under the current repository’s license.

[tmorrell]

I'd lean toward putting the title first and simplifying the template.

[karkraeg]

Funder + Number

Two funding entries, second one with URL

No award number

Award number + title

Only award number

Just a funder name

[karkraeg]

Hi @tmorrell , is this the way you were thinking?

[tmorrell]

Could you add one or two screenshots?

[wgresshoff]

Perhaps the wrong place here (surely the wrong place here!) but it's just a thought: did someone bother to look if the change has implications on OAI-PMH output? If the transformers rely on number AND title instead of number OR title?!

[tmorrell]

@wgresshoff Funding isn't serialized in the default dc oai output. The DataCite output should be alright assuming I understand how missing is working. @karkraeg if you've got a test instance up it would be worth running through the export formats on an example record and making sure they don't break.

[tmorrell]

Suggested change

	<span class="ui mini basic ml-0 label {% if item.award.title_l10n %}mr-5{% endif %}" id="number-label-{{ index }}">
	<span class="ui mini basic label {% if not item.award.title_l10n %}ml-0{% endif %}" id="number-label-{{ index }}">

[tmorrell]

The serialized formats are fine. Since inveniosoftware/invenio-vocabularies#429 has been released it would be great to get this change merged so the award number shows up consistently.

There seems to be a bit of a spacing issue around the award number:

I've just made a suggestion that re-works the spacing. I think we should merge after that change is added, unless folks want to do more re-designing.

Here is the UI after the change:

[karkraeg]

The serialized formats are fine. Since inveniosoftware/invenio-vocabularies#429 has been released it would be great to get this change merged so the award number shows up consistently.

Sorry Tom that I missed that... Looks nice this way, I'd opt for merging this.

[tmorrell]

Could you make the change #2912 (comment) in your fork? Then I should be able to merge it.