Merge pull request #190 from invenia/ah/backport-stdlib-mod-nothing

Backport stdlib mod nothing
invenia · Oct 12, 2022 · c03bd20 · c03bd20 · iamed2 · Oct 13, 2022
2 parents 00c6686 + 1844a4f
commit c03bd20
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/Project.toml b/Project.toml
@@ -2,7 +2,7 @@ name = "Memento"
 uuid = "f28f55f0-a522-5efc-85c2-fe41dfb9b2d9"
 license = "MIT"
 authors = ["Invenia Technical Computing"]
-version = "1.2.0"
+version = "1.2.1"
 
 [deps]
 Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"

diff --git a/src/stdlib.jl b/src/stdlib.jl
@@ -35,3 +35,7 @@ function substitute!(level::LogLevel=min_enabled_level(global_logger()))
     global_logger(BaseLogger(level))
     notice(getlogger(@__MODULE__), "Substituting global logging with Memento")
 end
+
+# `getlogger` dispatch to reroute stdlib messages with `mod=nothing` to the root logger, 
+# similar to calling `getlogger` with no arguments.
+getlogger(::Nothing) = getlogger()
diff --git a/test/stdlib.jl b/test/stdlib.jl
@@ -1,5 +1,6 @@
 @testset "stdlib" begin
     orig_logger = Base.CoreLogging.global_logger()
+    @test getlogger(nothing) == getlogger()
 
     try
         logger = getlogger("Memento")