Updates to travis-ci config to use tox #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This project appears to already use tox for running tests in multiple environments, so this change makes use of the tox-travis module so that travis-ci builds can easily call into tox to run the test suite instead of maintaining two callpaths into the nosetest based test suite. This commit force using Xenial on travis-ci so as to support python 3.7 Signed-off-by: zachwick <[email protected]>
|
@civilframe Out of curiosity, what was the rationale for closing this? I’m curious since no reason was provided and the PR wasn’t merged. |
|
Hi Zach, our SDKs are generated, so we don't merge PRs into it. The original source that generates this SDK is private. I will file this for my team to consider incorporating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project appears to already use tox for running tests in multiple
environments, so this change makes use of the tox-travis module so
that travis-ci builds can easily call into tox to run the test suite
instead of maintaining two callpaths into the nosetest based test suite.
This commit forces using Xenial on travis-ci so as to support python 3.7
Signed-off-by: zachwick [email protected]