Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to travis-ci config to use tox #12

Closed
wants to merge 1 commit into from

Conversation

zachwick
Copy link

This project appears to already use tox for running tests in multiple
environments, so this change makes use of the tox-travis module so
that travis-ci builds can easily call into tox to run the test suite
instead of maintaining two callpaths into the nosetest based test suite.

This commit forces using Xenial on travis-ci so as to support python 3.7

Signed-off-by: zachwick [email protected]

This project appears to already use tox for running tests in multiple
environments, so this change makes use of the tox-travis module so
that travis-ci builds can easily call into tox to run the test suite
instead of maintaining two callpaths into the nosetest based test suite.

This commit force using Xenial on travis-ci so as to support python 3.7

Signed-off-by: zachwick <[email protected]>
@alexnsolo alexnsolo closed this Apr 22, 2019
@zachwick
Copy link
Author

zachwick commented Apr 22, 2019

@civilframe Out of curiosity, what was the rationale for closing this? I’m curious since no reason was provided and the PR wasn’t merged.

@alexnsolo
Copy link
Contributor

Hi Zach, our SDKs are generated, so we don't merge PRs into it. The original source that generates this SDK is private. I will file this for my team to consider incorporating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants