Updates sample code in README to be runnable #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zachwick <[email protected]>
This project appears to already use tox for running tests in multiple environments, so this change makes use of the tox-travis module so that travis-ci builds can easily call into tox to run the test suite instead of maintaining two callpaths into the nosetest based test suite. This commit force using Xenial on travis-ci so as to support python 3.7 Signed-off-by: zachwick <[email protected]>
|
Thanks @zachwick - the filter_companies method was removed in the last release. We went ahead and changed the example to use intraday prices :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example code in the README uses a
filter_companiesmethod that does not seem to be defined anywhere. This PR replaces that undefined method with a simple call toget_companyso that users can quickly and easily have a running code sample to test their installation of the python SDK.