Strings reworked #74
Strings reworked #74
Conversation
|
Thanks for the improvements, @comradekingu. I'll scan through them and review them. |
There was a problem hiding this comment.
I went quickly through the messages and most of the changes improves the user experience, I think. Nevertheless, there are some issues that need to be resolved.
I usually commented only once for the issue type. So there can be other messages requiring the change (e.g. JSignPdf letter-casing, using non-ASCII characters in console. and hlp. messages).
| console.certificateChainEmpty=No private key was found. Check the keystore settings (keystore type, filepath, password, key alias). | ||
| console.certificateExpired=Certificate {0} expired already. | ||
| console.certificateNotForSignature=Certificate {0} is not intended for digital signing. | ||
| console.certificateNotForSignature=The \"{0}\" certificate is not intended to be signed digitally. |
There was a problem hiding this comment.
I think this fix changes the meaning of the message.
IIUC the changed sentence, it sounds as we want to sign the certificate.
It's supposed to be the other way around. The certificate signs PDF. The X.509 certificates may contain a key-usage extension. It says if the certificate is intended for creating digital signatures.
| console.keys=Key aliases in the (JKS) keystore: | ||
| console.keystores=Available (JKS) keystore types: |
There was a problem hiding this comment.
The JKS shouldn't be mentioned here. The messages are used for non-JKS keystore types too (e.g. PKCS12, JCEKS, PKCS11)
| error.vs.pageNotANumber=Page has to be an integer. | ||
| error.keystoreNull=The keystore was not loaded. Check if the keystore type, path and password are valid. | ||
| error.sslHandshakeException=SSL connection failed — the certificate of the server is probably not known. You can use InstallCert Tool to import the certificate to Java Keystore. | ||
| error.vs.pageNotANumber=The page number has to whole number. |
There was a problem hiding this comment.
| error.vs.pageNotANumber=The page number has to whole number. | |
| error.vs.pageNotANumber=The page number has to be the whole number. |
| console.createSignature=Creating signature | ||
| console.creatingTsaClient=Creating TSA client. | ||
| console.criticalExtensionNotSupported=Certificate {0} contains critical extension with OID "{1}" which is not recognized by JSignPdf - skipping. | ||
| console.criticalExtensionNotSupported=The {0} certificate contains a critical (OID "{1}") extension not recognized by JSignPDF — skipping. |
There was a problem hiding this comment.
| console.criticalExtensionNotSupported=The {0} certificate contains a critical (OID "{1}") extension not recognized by JSignPDF — skipping. | |
| console.criticalExtensionNotSupported=The {0} certificate contains a critical extension (OID "{1}") not recognized by JSignPdf - skipping. |
- We should leave the name to be
JSignPdf, it's used in the majority of places (web, jar-name, ...) - Also I would keep the
console.*andhlp.*messages ASCII-based as some terminals (pointing on you, Windowscmd) could have issues with "advanced" character (—,…)
| gui.contact.label=Co&ntact (optional) | ||
| gui.encryptionCertFile.label=Certificate file for encryption | ||
| gui.fileNotExists.error={0} doesn''t exist or it is not readable. | ||
| gui.fileNotExists.error={0} doesn't exist or it is not readable. |
There was a problem hiding this comment.
Two quotes are intentional. It's an escape sequence.
See https://docs.oracle.com/javase/8/docs/api/java/text/MessageFormat.html#:~:text=Within%20a%20String,representing%20string%20%22%7B%27%7D%22%2C%20not%20%22%7B%7D%22.
| hlp.ksFile=Sets (JKS) keystore file — as the value use the path on which is file with private key(s) located (.p12, .pfx, .jks, …). Some keystores haven't keys stored in a file (e.g. Windows keystore — WINDOWS-MY), then don't use this option. | ||
| hlp.ksPwd=Password to (JKS) keystore | ||
| hlp.ksType=Sets (JKS) keystore type (you can list possible values for this option -lkt argument) |
There was a problem hiding this comment.
Also here the JKS shouldn't be mentioned, as there are other types too.
And as help messages are printed to a terminal, I suggest avoiding the … character.
| hlp.loadProperties=Loads properties from a default file (created by GUI application). | ||
| hlp.loadPropertiesFile=Loads properties from the given file. The file can be create by copying the default property file .JSignPdf created by the GUI in the user home directory. | ||
| hlp.location=location of a signatue (e.g. Washington DC). Empty by default. | ||
| hlp.encryption=Encryption mode for the output PDF default value is NONE. Possible values are {0}. Use togethter with -upwd and -opwd in case of PASSWORD mode, and -ec in case of CERTIFICATE |
There was a problem hiding this comment.
| hlp.encryption=Encryption mode for the output PDF default value is NONE. Possible values are {0}. Use togethter with -upwd and -opwd in case of PASSWORD mode, and -ec in case of CERTIFICATE | |
| hlp.encryption=Encryption mode for the output PDF. The default value is NONE. Possible values are {0}. Use together with -upwd and -opwd in case of PASSWORD mode, and -ec in case of CERTIFICATE |
kwart
force-pushed
the
master
branch
6 times, most recently
from
f7efd80 to
9312988
Compare
2 participants
A lot of strings need to be put in quotes if that is to be the norm.