Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add @intlify/shared and vue-i18n v11.0.0 to peer dependencies #301

Closed

Conversation

NaokiHaba
Copy link
Contributor

@NaokiHaba NaokiHaba commented Dec 28, 2024

Description

Fix peer dependency version ranges to include ^11.0.0

Changes:

  • Extend peer dependency version ranges:
  • @intlify/shared: "^9.0.0 || ^10.0.0 || ^11.0.0"
  • vue-i18n: "^9.0.0 || ^10.0.0 || ^11.0.0"

fixes #300

Additional context

@NaokiHaba NaokiHaba marked this pull request as ready for review December 28, 2024 19:14
@userquin
Copy link
Member

shouldn't be added to the peer dependencies too?

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NaokiHaba
Welcome to contribution!

As @userquin mentioned, the root issue of this issue is the need to add ^11.0.0 to @intlify/shared in peer dependencies. Could you add it, please? 🙏

@kazupon kazupon added the improvement Includes backwards-compatible fixes label Dec 29, 2024
@NaokiHaba
Copy link
Contributor Author

NaokiHaba commented Dec 29, 2024

@NaokiHaba Welcome to contribution!

As @userquin mentioned, the root issue of this issue is the need to add ^11.0.0 to @intlify/shared in peer dependencies. Could you add it, please? 🙏

@kazupon @userquin

Thank you for your response. I understand. 🙇
I will proceed with creating the pull request. Once the changes are complete, I will notify you again.

@NaokiHaba NaokiHaba changed the title chore(deps): update @intlify/shared to v11.0.1 chore(deps): update @intlify/shared to v11.0.0 Dec 29, 2024
@NaokiHaba NaokiHaba changed the title chore(deps): update @intlify/shared to v11.0.0 chore(deps): update @intlify/shared to v11.0.0 with peer deps Dec 29, 2024
@NaokiHaba NaokiHaba changed the title chore(deps): update @intlify/shared to v11.0.0 with peer deps chore(deps): update @intlify/shared to v11.0.0 with peer dependencies Dec 29, 2024
@NaokiHaba NaokiHaba requested a review from kazupon December 29, 2024 02:19
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NaokiHaba
Thanks for your updates!
Do I correct in understanding that you updated this snapshot because the version of vue on which vue-i18n-extensions depends changed from 3.4 to 3.5, don’t you?

@kazupon
Copy link
Member

kazupon commented Dec 29, 2024

If possible, I would like to only update pnpm-lock.yaml in @intlify/shared in this PR. Can you do that?

@kazupon
Copy link
Member

kazupon commented Dec 29, 2024

I've noticed that we need vue-i18n@^v11.0.0 to peerDependecies from this issue
intlify/bundle-tools#431

the bellow log from that issue:

packages/frontend
└─┬ @intlify/unplugin-vue-i18n 6.0.2
  └─┬ @intlify/vue-i18n-extensions 7.0.0
    ├── ✕ unmet peer @intlify/shared@"^9.0.0 || ^10.0.0": found 11.0.1
    └── ✕ unmet peer vue-i18n@"^9.0.0 || ^10.0.0": found 11.0.1

@NaokiHaba
Copy link
Contributor Author

@NaokiHaba Thanks for your updates! Do I correct in understanding that you updated this snapshot because the version of vue on which vue-i18n-extensions depends changed from 3.4 to 3.5, don’t you?

Yes, that's exactly right! The snapshot and lint failures occurred because of the Vue dependency update from 3.4 to 3.5 in vue-i18n-extensions.

Here's what I'm seeing:

  1. Snapshot test failures (22 failed) showing changes in the AST structure, particularly around cached and patchFlag properties
  2. TypeScript/ESLint errors related to unsafe Function calls across multiple files

I chose to update these tests as they were failing after the dependency update.

If possible, I would like to only update pnpm-lock.yaml in @intlify/shared in this PR. Can you do that?

Of course, that's possible! I'll focus only on updating the pnpm-lock.yaml in @intlify/shared for this PR.

@kazupon
Copy link
Member

kazupon commented Dec 29, 2024

I apologize for the lack of context in my approach to this issue.
The Peer dependecies issue should be resolved by simply updating peerDependecies without updating the dependecies version.
So, it should be possible to resolve it only by updating the following.

diff --git a/package.json b/package.json
index a11c3f1..e75e121 100644
--- a/package.json
+++ b/package.json
@@ -59,10 +59,10 @@
     "vue": "^3.2.45"
   },
   "peerDependencies": {
-    "@intlify/shared": "^9.0.0 || ^10.0.0",
+    "@intlify/shared": "^9.0.0 || ^10.0.0 || ^11.0.0",
     "@vue/compiler-dom": "^3.0.0",
     "vue": "^3.0.0",
-    "vue-i18n": "^9.0.0 || ^10.0.0"
+    "vue-i18n": "^9.0.0 || ^10.0.0 || ^11.0.0"
   },
   "peerDependenciesMeta": {
     "@intlify/shared": {

@NaokiHaba
Copy link
Contributor Author

NaokiHaba commented Dec 29, 2024

I apologize for the lack of context in my approach to this issue. The Peer dependecies issue should be resolved by simply updating peerDependecies without updating the dependecies version. So, it should be possible to resolve it only by updating the following.

Thanks for the clarification!

I'll update both vue-i18n in the peerDependencies field accordingly.

@kazupon
Copy link
Member

kazupon commented Dec 29, 2024

Ah, You need to revert dependecies field (revert https://github.com/intlify/vue-i18n-extensions/pull/301/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R24) and pnpm-lock.yaml

@kazupon kazupon changed the title chore(deps): update @intlify/shared to v11.0.0 with peer dependencies chore(deps): add @intlify/shared and vue-i18n v11.0.0 to peer dependencies Dec 29, 2024
@NaokiHaba
Copy link
Contributor Author

Ah, You need to revert dependecies field (revert https://github.com/intlify/vue-i18n-extensions/pull/301/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R24) and pnpm-lock.yaml

I've made the requested changes:

  1. Reverted the dependencies field changes from PR chore(deps): add @intlify/shared and vue-i18n v11.0.0 to peer dependencies #301
  2. Reverted the pnpm-lock.yaml changes

@@ -1293,6 +1293,7 @@ packages:
/@intlify/[email protected]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, pnpm-lock.yaml has not reverted completly...
You can try again with a new PR, committing only the following changes.

diff --git a/package.json b/package.json
index a11c3f1..e75e121 100644
--- a/package.json
+++ b/package.json
@@ -59,10 +59,10 @@
     "vue": "^3.2.45"
   },
   "peerDependencies": {
-    "@intlify/shared": "^9.0.0 || ^10.0.0",
+    "@intlify/shared": "^9.0.0 || ^10.0.0 || ^11.0.0",
     "@vue/compiler-dom": "^3.0.0",
     "vue": "^3.0.0",
-    "vue-i18n": "^9.0.0 || ^10.0.0"
+    "vue-i18n": "^9.0.0 || ^10.0.0 || ^11.0.0"
   },
   "peerDependenciesMeta": {
     "@intlify/shared": {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the incomplete revert. I'll create a new PR that includes only the necessary pnpm-lock.yaml changes. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Includes backwards-compatible fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unmet peer @intlify/shared@"^9.0.0 || ^10.0.0": found 11.0.1
3 participants