-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): add @intlify/shared
and vue-i18n
v11.0.0 to peer dependencies
#301
chore(deps): add @intlify/shared
and vue-i18n
v11.0.0 to peer dependencies
#301
Conversation
shouldn't be added to the peer dependencies too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NaokiHaba
Welcome to contribution!
As @userquin mentioned, the root issue of this issue is the need to add ^11.0.0
to @intlify/shared
in peer dependencies. Could you add it, please? 🙏
Thank you for your response. I understand. 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NaokiHaba
Thanks for your updates!
Do I correct in understanding that you updated this snapshot because the version of vue on which vue-i18n-extensions depends changed from 3.4 to 3.5, don’t you?
If possible, I would like to only update |
I've noticed that we need the bellow log from that issue:
|
Yes, that's exactly right! The snapshot and lint failures occurred because of the Vue dependency update from 3.4 to 3.5 in vue-i18n-extensions. Here's what I'm seeing:
I chose to update these tests as they were failing after the dependency update.
Of course, that's possible! I'll focus only on updating the |
I apologize for the lack of context in my approach to this issue. diff --git a/package.json b/package.json
index a11c3f1..e75e121 100644
--- a/package.json
+++ b/package.json
@@ -59,10 +59,10 @@
"vue": "^3.2.45"
},
"peerDependencies": {
- "@intlify/shared": "^9.0.0 || ^10.0.0",
+ "@intlify/shared": "^9.0.0 || ^10.0.0 || ^11.0.0",
"@vue/compiler-dom": "^3.0.0",
"vue": "^3.0.0",
- "vue-i18n": "^9.0.0 || ^10.0.0"
+ "vue-i18n": "^9.0.0 || ^10.0.0 || ^11.0.0"
},
"peerDependenciesMeta": {
"@intlify/shared": { |
Thanks for the clarification! I'll update both |
Ah, You need to revert |
@intlify/shared
and vue-i18n
v11.0.0 to peer dependencies
I've made the requested changes:
|
@@ -1293,6 +1293,7 @@ packages: | |||
/@intlify/[email protected]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, pnpm-lock.yaml
has not reverted completly...
You can try again with a new PR, committing only the following changes.
diff --git a/package.json b/package.json
index a11c3f1..e75e121 100644
--- a/package.json
+++ b/package.json
@@ -59,10 +59,10 @@
"vue": "^3.2.45"
},
"peerDependencies": {
- "@intlify/shared": "^9.0.0 || ^10.0.0",
+ "@intlify/shared": "^9.0.0 || ^10.0.0 || ^11.0.0",
"@vue/compiler-dom": "^3.0.0",
"vue": "^3.0.0",
- "vue-i18n": "^9.0.0 || ^10.0.0"
+ "vue-i18n": "^9.0.0 || ^10.0.0 || ^11.0.0"
},
"peerDependenciesMeta": {
"@intlify/shared": {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for the incomplete revert. I'll create a new PR that includes only the necessary pnpm-lock.yaml
changes. 🙇
Description
Fix peer dependency version ranges to include ^11.0.0
Changes:
fixes #300
Additional context