[mock_uss] Move mock_uss webapp to app module #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmis
approved these changes
Oct 14, 2025
| @@ -1,6 +0,0 @@ | |||
| from monitoring.mock_uss import SERVICE_MESSAGESIGNING, config | |||
There was a problem hiding this comment.
Is this removal intended? Is it because the check made here is unnecessary?
There was a problem hiding this comment.
Actually, it was removed because SERVICE_MESSAGESIGNING is no longer as easily accessible and it didn't seem worthwhile to adapt this check, but that functionality change probably should probably be in a separate PR; I've re-added the check without the constant.
There was a problem hiding this comment.
Ah, and now I'm recalling the other reason: Config.CERT_BASE_PATH doesn't exist, nor does ENV_KEY_CERT_BASE_PATH -- basically, this code is broken.
| webapp = MockUSS(__name__) | ||
| webapp.secret_key = os.environ.get("SECRET_KEY") or os.urandom(24) | ||
| if os.environ.get("MOCK_USS_PROXY_VALUES"): | ||
| values = os.environ.get("MOCK_USS_PROXY_VALUES", "").split(",") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes a small step toward #1218 by placing the actual
webappFlask server in app.py rather than init.py. This does not resolve the issue as other __init__s still automatically pull inwebapp, but this is a start.