Skip to content

Conversation

BenjaminPelletier
Copy link
Member

#1207 introduced a more type-safe of using SynchronizedValue, but retained the old usage as deprecated. This PR removes the old usage entirely and fixes problems discovered while upgrading to the new usage.

@BenjaminPelletier BenjaminPelletier marked this pull request as ready for review October 10, 2025 18:45
Copy link
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mickmis mickmis merged commit 34a1248 into interuss:main Oct 14, 2025
21 checks passed
@mickmis
Copy link
Contributor

mickmis commented Oct 14, 2025

After merge this PR seems to have caused the CI to fail: https://github.com/interuss/monitoring/actions/runs/18502637213/job/52723351736#step:4:942
I'm checking it.

@mickmis
Copy link
Contributor

mickmis commented Oct 14, 2025

So the CI succeeded on the PR by mistake: https://github.com/interuss/monitoring/actions/runs/18413973142/job/52473093945#step:4:689
The docker image failed to be built so Docker downloaded the image from the internet, using obviously an old version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants