[BR-2060]: fix/newobject single lookup#41
Open
jzunigax2 wants to merge 2 commits into
Open
Conversation
- Replaced the preUploadCheck function with findFile for better clarity and efficiency in checking file existence. - Introduced splitNameExt to encapsulate name and extension parsing logic. - Updated NewObject and Update methods to utilize findFile for improved file metadata handling. - Enhanced error handling and reduced redundant code in file checks.
jzunigax2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewObjectpreviously paginated the entire parent directory viaListAllFiles(50 entries per request, sequential) to resolve a single file.This change rewrites
NewObjectto do a single-file lookup using the existence-check + metadata endpoints already exposed by the SDK, Lookup cost drops from O(directory size) to a constant 2 API calls.