[PB-4903]: Fix password modal closing on eye icon click #1685
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying drive-web with
|
| Latest commit: |
984a78d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a453ffcb.drive-web.pages.dev |
| Branch Preview URL: | https://fix-eye-icon-closes-modal.drive-web.pages.dev |
| <div onMouseDown={handleMouseDown} role="none"> | ||
| <form onSubmit={handleSubmit}> |
There was a problem hiding this comment.
Hey @terrerox, the project https://github.com/internxt/ui is ours. Perhaps it would be better to try adding the fix to the Modal component directly instead of adding a patch here, as it could happen in other places where the Modal component is used that the click bubbles up to the backdrop and closes because the click event comes from the children.
What do you think?
There was a problem hiding this comment.
I see it’s already defined, thanks!
There was a problem hiding this comment.
What I have seen completely disables the functionality of closing the modal window when clicking outside of it, but I think what we should do is prevent the click event from bubbling in the components that we pass as children to the Modal, since what happens is undesirable
There was a problem hiding this comment.
Got it! I just opened a PR on @internxt/ui. Looking forward to your feedback. @CandelR
terrerox
force-pushed
the
fix/eye-icon-closes-modal
branch
from
ddad648 to
11af543
Compare
…gePasswordModal props
terrerox
force-pushed
the
fix/eye-icon-closes-modal
branch
from
33e6fab to
f01ba53
Compare
|
Description
Add preventClosing prop to prevent modal from closing when clicking the password visibility toggle icon.
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes