[PB-4905]: Fix white screen blink on page load #1682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…diately The theme was being applied after React mounted, causing a visual flash. This fix adds an inline script in index.html that applies the dark mode class synchronously during page load, before React initialization. Also persists the isDark state properly using JSON.parse() instead of string comparison.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
terrerox
changed the title
Deploying drive-web with
|
| Latest commit: |
c93569a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://620cd351.drive-web.pages.dev |
| Branch Preview URL: | https://fix-white-screen-blink.drive-web.pages.dev |
CandelR
approved these changes
Oct 1, 2025
src/app/theme/ThemeProvider.tsx
Outdated
|
|
||
| const toggleTheme = (theme: Theme) => setCurrentTheme(theme); | ||
|
|
||
| const persistIsDark = (value: boolean) => { |
There was a problem hiding this comment.
nit: the name persistIsDark is a bit confusing; you need to know what isDark is. persistDarkTheme makes it clearer what it does: persist the dark theme.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The theme was being applied after React mounted, causing a visual flash. This fix adds an inline script in index.html that applies the dark mode class synchronously during page load, before React initialization. Also persists the isDark state properly using JSON.parse() instead of string comparison.
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes