Skip to content

[PB-5019]: Fix sonar issues #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 8, 2025
Merged

[PB-5019]: Fix sonar issues #1670

merged 10 commits into from
Oct 8, 2025

Conversation

@terrerox
Copy link
Contributor

@terrerox terrerox commented Sep 16, 2025 •
edited
Loading

Description

Removed redundant cycles, reduced cognitive complexity, and simplified nested code.

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Additional Notes

@terrerox terrerox self-assigned this Sep 16, 2025
@terrerox terrerox requested a review from CandelR as a code owner September 16, 2025 22:07
@vercel
Copy link

vercel bot commented Sep 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
drive-web Ready Ready Preview Comment Oct 8, 2025 8:59pm

@terrerox terrerox marked this pull request as draft September 16, 2025 22:07
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 16, 2025 •
edited
Loading

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 885a87f
Status: ✅  Deploy successful!
Preview URL: https://951dd122.drive-web.pages.dev
Branch Preview URL: https://fix-sonar-issues.drive-web.pages.dev

View logs

@terrerox terrerox force-pushed the fix/sonar-issues branch 2 times, most recently from 42f8b25 to d041f3d Compare September 17, 2025 01:49
@terrerox
test: add unit tests for canFileBeCached function to validate file si…
708c723 
…ze conditions
@terrerox
refactor: extract authentication error handling and success logic int…
93a9588 
…o separate functions
@terrerox
refactor: improve search functionality and UI class name management i…
2925616 
…n Navbar component
@terrerox
refactor: simplify error handling and password state management in Si…
cec8969 
…gnUp component
@terrerox
refactor: move DatabaseProvider, DatabaseCollection, and LRUCacheType…
6198d4a 
…s enums to a new types file
@terrerox
refactor: streamline search result rendering by extracting renderSear…
0f8862d 
…chState function
@terrerox
refactor: move uploadFileUint8Array function to upload-utils and upda…
59d0541 
…te imports in NetworkFacade and upload modules
@terrerox
test: add unit tests for uploadFileUint8Array error handling
3a7b32f
@terrerox terrerox marked this pull request as ready for review September 18, 2025 17:10
@terrerox terrerox requested a review from a team as a code owner September 18, 2025 17:10
CandelR
CandelR approved these changes Sep 19, 2025
View reviewed changes
Copy link
Collaborator

@CandelR CandelR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @terrerox, this looks good.
Just one thing to keep in mind, as I'm starting to see a lot of PRs for this task: if you see that the task is very large, apart from dividing it into several PRs, it would also be a good idea to divide the task into different subtasks. This will make QA easier, so you can specify what needs to be tested in each one and make life easier for QA :)

@terrerox terrerox changed the title [PB-4522]: Fix sonar issues [PB-5019]: Fix sonar issues Sep 23, 2025
@terrerox
Copy link
Contributor Author

terrerox commented Sep 29, 2025

Hey @terrerox, this looks good. Just one thing to keep in mind, as I'm starting to see a lot of PRs for this task: if you see that the task is very large, apart from dividing it into several PRs, it would also be a good idea to divide the task into different subtasks. This will make QA easier, so you can specify what needs to be tested in each one and make life easier for QA :)

Do I need to wait for @internxt/cryptography ’s approval before sending this task to QA?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@terrerox terrerox merged commit d2276a5 into master Oct 8, 2025
16 checks passed
@terrerox terrerox deleted the fix/sonar-issues branch October 8, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sg-gs sg-gs sg-gs approved these changes

@CandelR CandelR CandelR approved these changes

Assignees

@terrerox terrerox

Labels

ready-for-preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@terrerox @sg-gs @CandelR