[_] fix(usage): fix daily usage when there is a gap between monthly usages #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apsantiso
had a problem deploying
to
development
GitHub Actions
Failure
apsantiso
force-pushed
the
fix/usage-fix-daily-usage
branch
from
d6f1499 to
30e5052
Compare
apsantiso
force-pushed
the
fix/usage-fix-daily-usage
branch
from
30e5052 to
2d39d7c
Compare
|
sg-gs
requested changes
Oct 30, 2025
| const todayFile = newFile({ | ||
| it('When file was created before usage period and size increased, then should create daily usage with positive delta', async () => { | ||
| const usagePeriod = new Date('2024-06-15T00:00:00.000Z'); | ||
| const dateBeforeUsage = new Date('2024-06-10T00:00:00.000Z'); |
Member
There was a problem hiding this comment.
Let's subtract the days with dayjs from the usagePeriod
| // Files created the same day do not need a daily usage entry, they will be included in the next monthly usage | ||
| const isFileCreatedToday = Time.isToday(newFileData.createdAt); | ||
| const recentUsage = | ||
| await this.usageRepository.getMostRecentMonthlyOrYearlyUsage(user.uuid); |
Member
There was a problem hiding this comment.
Monthly should be daily as we talked
sg-gs
requested changes
Oct 30, 2025
| .spyOn(usageRepository, 'getMostRecentMonthlyOrYearlyUsage') | ||
| .mockResolvedValue(existingUsage); | ||
|
|
||
| const result = await service.addDailyUsageChangeOnFileSizeChange( |
Member
There was a problem hiding this comment.
This function may return void as it 'adds' things, otherwise the naming may be wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes daily usage calculation when there is a gap between monthly usages. Files created after the most recent usage period should not generate daily usage entries, as they will be included in the next monthly calculation.
Changes
addDailyUsageChangeOnFileSizeChange