fix qa issues, clean up settings because of that

internetstandards · Nov 8, 2024 · 6892e6a · 6892e6a
1 parent fe812a9
commit 6892e6a
Show file tree

Hide file tree

Showing 6 changed files with 453 additions and 480 deletions.
diff --git a/Makefile b/Makefile
@@ -253,7 +253,7 @@ vulture: ${app} ## Check for unused code
 	${python} -m vulture ${pysrcdirs}
 
 ruff: ${app} ## Faster than black, might autoformat some things
-	${python} -m ruff ${pysrcdirs}
+	${python} -m ruff check ${pysrcdirs}
 
 bandit: ${app} ## Run basic security audit
 	${python} -m bandit --configfile bandit.yaml -r ${pysrcdirs}

diff --git a/dashboard/internet_nl_dashboard/logic/domains.py b/dashboard/internet_nl_dashboard/logic/domains.py
@@ -38,7 +38,8 @@ def suggest_subdomains(domain: str, period: int = 370):
 
     # call SUBDOMAIN_SUGGESTION_SERVER_ADDRESS
     response = requests.get(config.SUBDOMAIN_SUGGESTION_SERVER_ADDRESS,
-                            params={'domain': extract.domain, 'suffix': extract.suffix, 'period': period})
+                            params={'domain': extract.domain, 'suffix': extract.suffix, 'period': period},
+                            timeout=10)
 
     if response.status_code != 200:
         log.error("Failed to retrieve subdomain suggestions from  %s.", config.SUBDOMAIN_SUGGESTION_SERVER_ADDRESS)