Merge pull request #545 from internetstandards/error_handling

Suggest subdomains should be a GET interface instead of POST

dashboard/internet_nl_dashboard/tests/test_domain_management.py

@@ -9,6 +9,7 @@
 import pytest
 import responses
 from constance.test import override_config
+from django.contrib.auth.models import User
 from websecmap.organizations.models import Url
 
 from dashboard.internet_nl_dashboard.logic.domains import (ServerError, add_domains_from_raw_user_data, clean_urls,
@@ -38,6 +39,24 @@ def test_suggest_subdomains(db, caplog):
         suggest_subdomains("broken.nl")
 
 
+@responses.activate
+def test_suggest_subdomains_http(db, client):
+    responses.add(responses.GET, 'http://localhost:8001/?domain=test&suffix=nl&period=370', json=["test"], status=200)
+    responses.add(responses.GET, 'http://localhost:8001/?domain=notexisting&suffix=nl&period=370', json=[], status=404)
+    responses.add(responses.GET, 'http://localhost:8001/?domain=broken&suffix=nl&period=370', json=[], status=500)
+
+    assert client.get("/data/urllist/suggest-subdomains/",
+                      {"domain": "test.nl"}).status_code == 302, \
+        "unauthenticated request should result in login redirect"
+
+    user = User.objects.create(username="test")
+    client.force_login(user)
+
+    response = client.get("/data/urllist/suggest-subdomains/", {"domain": "test.nl"})
+    print(response)
+    assert response.json() == ["test"]
+
+
 @override_config(DASHBOARD_MAXIMUM_DOMAINS_PER_LIST=5000)
 def test_add_domains_from_raw_user_data(db, current_path, redis_server):
     """

dashboard/internet_nl_dashboard/views/domains.py

@@ -17,9 +17,9 @@
 
 @login_required(login_url=LOGIN_URL)
 def suggest_subdomains_(request) -> JsonResponse:
-    request = get_json_body(request)
-    domain = request.get("domain", "")
-    period = request.get("period", 370)
+    domain = request.GET.get("domain", "")
+    period = request.GET.get("period", 370)
+
     try:
         result = JsonResponse(suggest_subdomains(domain, period), encoder=JSEncoder, safe=False)
     except ValueError: