Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest v3 Upgrade take 2 #1042

Merged
merged 25 commits into from
Aug 13, 2024
Merged

Manifest v3 Upgrade take 2 #1042

merged 25 commits into from
Aug 13, 2024

Conversation

cgorringe
Copy link
Member

Test this PR in Chrome, Firefox, and Edge. Safari hasn't been tested yet. This is primarily for the Chrome store.

Anish Sarangi and others added 23 commits April 12, 2023 05:18
first commit upgrading to manifest v3
a5abc67
use chrome.windows.getCurrent get height and width
c6d3a66
update the request header in the rules file
9c7fd9c
updated the version and move some background.js variable to chrome.st…
c809c01 
…orage.local
move globalAPICache to chrome.storage
22b3e2d
move gToolbarStates to chrome.storage
dd71149
Merge branch 'master' of https://github.com/internetarchive/wayback-m…
c86051d 
…achine-webextension into manifest-v3-upgrade
Merge remote-tracking branch 'origin/master' into manifest-v3-upgrade
8e2623e
remove declarativeNetRequest request from manifest
6a395cc
@cgorringe
remove constants from persistent storage
1fa0b8a
@cgorringe
globalAPICache holds temp data not needed in storage
f805235
@cgorringe
fixing async/await calls
08aa8cf
@cgorringe
gStatusCode removed since no longer used
1daf0f1
@cgorringe
fixed bug that was introduced in incrementCount()
d6b01c7
@cgorringe
missed an async
d217a45
@cgorringe
v3.4.2
322d424
@cgorringe
stores toolbar states using TabData utility functions instead of gToo…
34f2b47 
…lbarStates
@cgorringe
clear toolbar state only if state changes
8323f32
@cgorringe
got running in Firefox, with a warning still
f287e60
@cgorringe
tweak efficiancy of getting toolbar state
b6ea6e4
@cgorringe
switch to storage.session for waybackCountCache
7717b54
@cgorringe
remove debug logs and cleanup commented code
5766273
@cgorringe
Merge branch 'master' into manifest-v3-upgrade2
bd8ea86
@cgorringe cgorringe added the needs testing Please help us test this! label Aug 9, 2024
@cgorringe
Copy link
Member Author

cgorringe commented Aug 13, 2024 •
edited
Loading

Currently, "404 Page Not Found" errors aren't showing the red dot, but "410 Page has gone" errors are caught correctly. Will test again and do a separate PR. (On further testing, it worked! so I don't know what went wrong, but it was temporary.)

@cgorringe
Copy link
Member Author

Safari failed to load with these 2 errors:

  • An extension with a non-persistent background page cannot listen to webRequest events. (This went away after removing "webRequest" from "permissions" in the manifest.)

  • The service_worker script failed to load due to an error.

Will merge this PR, then deal with Safari errors later.

@cgorringe cgorringe merged commit d56a9cb into master Aug 13, 2024
1 check passed
@cgorringe cgorringe removed the needs testing Please help us test this! label Aug 14, 2024
@cgorringe cgorringe mentioned this pull request Aug 14, 2024
Closed
@anishsarangi anishsarangi mentioned this pull request Aug 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cgorringe