Skip to content

WEBDEV-7818 Allow facetPaneVisible prop to function without smart facets #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2025
+5 −9
Merged

WEBDEV-7818 Allow facetPaneVisible prop to function without smart facets #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
531454b
Allow facetPaneVisible prop to function even without smart facets
latonv Oct 3, 2025
8b18eb3
Make facetPaneVisible property reflected to attr
latonv Oct 6, 2025
caf16fc
Remove unused import in app-root
latonv Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app-root.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import type { AnalyticsManagerInterface } from '@internetarchive/analytics-manag
import type { CollectionBrowser } from '../src/collection-browser';

import '../src/collection-browser';
import { StringField } from '@internetarchive/iaux-item-metadata';

@customElement('app-root')
export class AppRoot extends LitElement {
Expand Down Expand Up @@ -490,6 +489,7 @@ export class AppRoot extends LitElement {
</div>
<div id="collection-browser-container">
<collection-browser
facetPaneVisible
.baseNavigationUrl=${'https://archive.org'}
.baseImageUrl=${'https://archive.org'}
.searchService=${this.searchService}
Expand Down
12 changes: 4 additions & 8 deletions src/collection-browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ export class CollectionBrowser
*/
@property({ type: String }) facetLoadStrategy: FacetLoadStrategy = 'eager';

@property({ type: Boolean }) facetPaneVisible = false;
@property({ type: Boolean, reflect: true }) facetPaneVisible = false;

@property({ type: Boolean }) clearResultsOnEmptyQuery = false;

Expand Down Expand Up @@ -675,14 +675,10 @@ export class CollectionBrowser
*/
private get desktopLeftColumnTemplate(): TemplateResult {
return html`
<div
id="left-column"
class="column"
?hidden=${this.showSmartFacetBar && !this.facetPaneVisible}
>
<div id="left-column" class="column" ?hidden=${!this.facetPaneVisible}>
${this.facetTopViewSlot}
<div id="facets-header-container">
<h2 id="facets-header" class="sr-only">Filters</h2>
<h2 id="facets-header" class="sr-only">${msg('Filters')}</h2>
${this.resultsCountTemplate} ${this.clearFiltersBtnTemplate(false)}
</div>
<div id="facets-container" aria-labelledby="facets-header">
Expand Down Expand Up @@ -736,7 +732,7 @@ export class CollectionBrowser
private get rightColumnTemplate(): TemplateResult {
const rightColumnClasses = classMap({
column: true,
'full-width': this.showSmartFacetBar && !this.facetPaneVisible,
'full-width': !this.facetPaneVisible,
'smart-results-spacing': !!this.showSmartResults,
});

Expand Down
Loading