Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Polyfill CustomEvent constructor #444

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

cdrini
Copy link
Contributor

@cdrini cdrini commented Sep 14, 2020

This was causing IE11 to brick. Apparently not supported by core-js :(
zloirock/core-js#354

This was causing IE11 to brick. Apparently not supported by core-js :(
zloirock/core-js#354
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #444 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   63.09%   63.15%   +0.06%     
==========================================
  Files          34       34              
  Lines        3636     3642       +6     
  Branches      687      688       +1     
==========================================
+ Hits         2294     2300       +6     
  Misses       1084     1084              
  Partials      258      258              
Impacted Files Coverage Δ
src/js/BookReader.js 66.45% <100.00%> (+0.02%) ⬆️
src/js/BookReader/utils.js 84.21% <100.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c288a...ab802ad. Read the comment docs.

@cdrini cdrini merged commit db5d0bd into internetarchive:master Sep 14, 2020
@cdrini
Copy link
Contributor Author

cdrini commented Sep 14, 2020

Tested on IE11 ✅

@cdrini cdrini deleted the fix/browser-compat branch September 14, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants