Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): add tests for various not-monetized scenarios #860

Merged
merged 2 commits into from
Jan 23, 2025
Merged

test(e2e): add tests for various not-monetized scenarios #860

merged 2 commits into from
Jan 23, 2025

Conversation

sidvishnoi
Copy link
Member

Context

Part of #610

Changes proposed in this pull request

@github-actions github-actions bot added the area: tests Improvements or additions to tests label Jan 22, 2025
@sidvishnoi sidvishnoi changed the title tests(e2e): add tests for various not-monetized scenarios test(e2e): add tests for various not-monetized scenarios Jan 22, 2025
sidvishnoi
sidvishnoi commented Jan 22, 2025
View reviewed changes
Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited
Loading

Extension builds preview

Name Link
Latest commit 784b264
Latest job logs Run #12927884084
BadgeDownload
BadgeDownload

raducristianpopa
raducristianpopa reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@raducristianpopa raducristianpopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking about two additional test scenarios as well.

  • disabled monetization link in iframe
  • ensure not monetized on a page with an iframe

@sidvishnoi
Copy link
Member Author

sidvishnoi commented Jan 23, 2025 •
edited
Loading

Iframe tests are pending on #842. As I'll be creating iframes dynamically in tests. I tried some in e2e-tests-iframe branch until I ran into limitations.

@sidvishnoi sidvishnoi merged commit c0fdfc8 into main Jan 23, 2025
10 checks passed
@sidvishnoi sidvishnoi deleted the e2e-not-monetized-state branch January 23, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducristianpopa raducristianpopa raducristianpopa approved these changes

Assignees
No one assigned
Labels
area: tests Improvements or additions to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidvishnoi @raducristianpopa