Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically added links in iframes are not monetized #842

Open
sidvishnoi opened this issue Jan 17, 2025 · 0 comments
Open

Dynamically added links in iframes are not monetized #842

sidvishnoi opened this issue Jan 17, 2025 · 0 comments
Assignees
@DarianM
Labels
bug Something isn't working
Milestone
Beta Release

Comments

@sidvishnoi
Copy link
Member

sidvishnoi commented Jan 17, 2025 •
edited
Loading

Add following iframe on a page with no link tags:

<iframe 
  allow="monetization"
  src="https://webmonetization.org/play/?wa=https://ilp.interledger-test.dev/sid"
></iframe>

Site does not become monetized. But if same page is navigated to in browser, the page is monetized. The playground adds link tags dynamically after page load.

Found when adding E2E tests with iframes - testing with playground not possible without this.
@sidvishnoi sidvishnoi added the bug Something isn't working label Jan 17, 2025
@sidvishnoi sidvishnoi mentioned this issue Jan 23, 2025
Merged
@RabebOthmani RabebOthmani added this to the Beta Release milestone Jan 29, 2025
@DarianM DarianM moved this from Backlog to In Progress in Web Monetization Extension Feb 3, 2025
@sidvishnoi sidvishnoi changed the title Dynamically added iframes are not monetized Dynamically added links in iframes are not monetized Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarianM DarianM

Labels
bug Something isn't working
Projects
Web Monetization Extension
Status: In Progress
Milestone
Beta Release
Development

No branches or pull requests
3 participants
@RabebOthmani @sidvishnoi @DarianM