feat: using open-payments-specifications submodule #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8c4d3d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
raducristianpopa
left a comment
raducristianpopa
left a comment
There was a problem hiding this comment.
I know the README is not updated yet, but I assume it is planned to do this in a later PR - git commands to initialize and download the submodule when cloning the repository.
Member
There was a problem hiding this comment.
Can you remind me why do we need to publish the OpenAPI specs alongside the SDK?
Contributor
Author
There was a problem hiding this comment.
To validate the responses from the API calls, using createOpenAPI from the openapi package
raducristianpopa
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
open-payments-specificationsas a submodule, pinning to v1.0.2 of the specsContext
Closes NOD-1