feat: adding callback server for peer-to-peer example #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mkurapov
changed the title
sidvishnoi
reviewed
Dec 1, 2025
mkurapov
commented
Dec 1, 2025
Comment on lines
+91
to
+92
| metadata: { | ||
| description: 'From peer-to-peer example script' |
Contributor
Author
There was a problem hiding this comment.
Adding metadata descriptions so its obvious how test wallet displays these, such that people can customize it for their use case
sidvishnoi
previously approved these changes
Dec 1, 2025
examples/peer-to-peer/index.js
Outdated
| return new Promise((resolve) => { | ||
| let server | ||
| const app = express() | ||
| app.use(express.json()) |
Member
There was a problem hiding this comment.
Don't need this.
Suggested change
| app.use(express.json()) |
mkurapov
force-pushed
the
mk/peer-to-peer-example-callback
branch
from
ce5549b to
5c844e4
Compare
sidvishnoi
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
peer-to-peerapp exampleContext
During hackathons, when participants used the
peer-to-peerexample app, after going through authorization at the test wallet, they would be redirect to a not so nice 202 "Accepted" page screen. Now, thepeer-to-peerexample includes a callback server for handling the finish redirect. IMO its a cleaner experience and also the script now demonstrates how they can use the finish in their own application.Before:
After: